Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use native-url instead of node's url for compat #61

Merged
merged 2 commits into from
Apr 1, 2020
Merged

fix: use native-url instead of node's url for compat #61

merged 2 commits into from
Apr 1, 2020
+29 −4

Conversation

pmmmwh
Copy link
Owner

@pmmmwh pmmmwh commented Apr 1, 2020 •
edited
Loading

This switches to the native-url module instead of the polyfilled node-url module (automatically done by Webpack 4, but will be removed in Webpack 5 and non-browser environments).

This will break IE11.

Fixes #42

@pmmmwh pmmmwh added the bug Something isn't working label Apr 1, 2020
@pmmmwh pmmmwh self-assigned this Apr 1, 2020
@pmmmwh pmmmwh merged commit 1cbe846 into master Apr 1, 2020
@pmmmwh pmmmwh deleted the fix/missing-node-url branch April 1, 2020 22:45
@MOZGIII MOZGIII mentioned this pull request Apr 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pmmmwh pmmmwh

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract runtime to a separate package and preprocess it with webpack for embedding
1 participant
@pmmmwh